Fix "Open Schema" CodeLens for schemas with URI without //#1224
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Apr 9, 2026
Merged
Conversation
Fixes redhat-developer/vscode-yaml#1220 Signed-off-by: David Thompson <davthomp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the "Open file from CodeLens" logic, there's a check for
://in an attempt to differentiate relative paths and URIs. I didn't realize that the//after the colon isn't a requirement for a URI, only the colon.What issues does this PR fix or reference?
Fixes redhat-developer/vscode-yaml#1220
Is it tested? How?
Manually (created the example extension, tested against that)